Avoid booting Rails to generate timestamp #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samandmoore
reviewed
Mar 24, 2025
| @@ -11,7 +11,9 @@ namespace :test_track do | |||
| end | |||
|
|
|||
| desc 'Generates build timestamp for fetching point-in-time split registries' | |||
| task generate_build_timestamp: :environment do | |||
| task :generate_build_timestamp do # rubocop:disable Rails/RakeEnvironment | |||
| require_relative '../../app/models/testtrack_cli' | |||
There was a problem hiding this comment.
it's small potatoes, but i'm wondering if we should move this class to lib since it's funky to require files that are in the app directory
samandmoore
previously approved these changes
Mar 24, 2025
betterment-policy-bot-production
bot
dismissed
samandmoore’s stale review
Invalidated by push of e53714e
rzane
force-pushed
the
rzane/skip-rails-env
branch
from
e53714e to
3b10a82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
test_track:generate_build_timestamptask currently depends on the Rails:environmenttask. Because this task just shells out to the CLI, this dependency really shouldn't be necessary and can add a significant overhead for applications that don't rely on the Rails environment to precompile assets.Other Information
/domain @Betterment/test_track_core
/platform @Betterment/test_track_core