Include all algorithms in hashing, even if some are not in consensusM…

…ethods
BimberLab · Jan 21, 2025 · 5a5740f · 5a5740f
1 parent 846a5a2
commit 5a5740f
Showing 1 changed file with 2 additions and 9 deletions.
diff --git a/singlecell/src/org/labkey/singlecell/CellHashingServiceImpl.java b/singlecell/src/org/labkey/singlecell/CellHashingServiceImpl.java
@@ -1238,15 +1238,8 @@ public File generateCellHashingCalls(File citeSeqCountOutDir, File outputDir, St
             Set<String> allowableBarcodes = parameters.getAllowableBarcodeNames();
             String allowableBarcodeParam = allowableBarcodes != null ? "c('" + StringUtils.join(allowableBarcodes, "','") + "')" : "NULL";
 
-            List<String> methodNames = parameters.methods.stream().filter(m -> {
-                if (totalCellBarcodes < m.getMinCells())
-                {
-                    ctx.getLogger().debug("Dropping method due to insufficient cells: " + m.name());
-                    return false;
-                }
-
-                return true;
-            }).map(CALLING_METHOD::getLabel).distinct().toList();
+            // NOTE: we do not need to filter total methods on min cells:
+            List<String> methodNames = parameters.methods.stream().map(CALLING_METHOD::getLabel).distinct().toList();
 
             List<String> consensusMethodNames = parameters.consensusMethods == null ? Collections.emptyList() : parameters.consensusMethods.stream().filter(m -> {
                 if (totalCellBarcodes < m.getMinCells())