From 5a5740f05df2336ec49707c0781c16b2780200ad Mon Sep 17 00:00:00 2001
From: bbimber <bbimber@gmail.com>
Date: Mon, 20 Jan 2025 16:29:29 -0800
Subject: [PATCH] Include all algorithms in hashing, even if some are not in
 consensusMethods

---
 .../org/labkey/singlecell/CellHashingServiceImpl.java | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

diff --git a/singlecell/src/org/labkey/singlecell/CellHashingServiceImpl.java b/singlecell/src/org/labkey/singlecell/CellHashingServiceImpl.java
index ef3f80482..a291d1aa7 100644
--- a/singlecell/src/org/labkey/singlecell/CellHashingServiceImpl.java
+++ b/singlecell/src/org/labkey/singlecell/CellHashingServiceImpl.java
@@ -1238,15 +1238,8 @@ public File generateCellHashingCalls(File citeSeqCountOutDir, File outputDir, St
             Set<String> allowableBarcodes = parameters.getAllowableBarcodeNames();
             String allowableBarcodeParam = allowableBarcodes != null ? "c('" + StringUtils.join(allowableBarcodes, "','") + "')" : "NULL";
 
-            List<String> methodNames = parameters.methods.stream().filter(m -> {
-                if (totalCellBarcodes < m.getMinCells())
-                {
-                    ctx.getLogger().debug("Dropping method due to insufficient cells: " + m.name());
-                    return false;
-                }
-
-                return true;
-            }).map(CALLING_METHOD::getLabel).distinct().toList();
+            // NOTE: we do not need to filter total methods on min cells:
+            List<String> methodNames = parameters.methods.stream().map(CALLING_METHOD::getLabel).distinct().toList();
 
             List<String> consensusMethodNames = parameters.consensusMethods == null ? Collections.emptyList() : parameters.consensusMethods.stream().filter(m -> {
                 if (totalCellBarcodes < m.getMinCells())