Walk back create-bam arg in CellRangerVDJWrapper

BimberLab · Aug 28, 2024 · e7b6133 · e7b6133
1 parent 0365054
commit e7b6133
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/SequenceAnalysis/resources/web/SequenceAnalysis/panel/AnalysisSectionPanel.js b/SequenceAnalysis/resources/web/SequenceAnalysis/panel/AnalysisSectionPanel.js
@@ -203,6 +203,8 @@ Ext4.define('SequenceAnalysis.panel.AnalysisSectionPanel', {
             title: 'Add Steps',
             border: false,
             width: 800,
+            autoScroll: true,
+            maxHeight: '90%',
             items: items,
             buttons: [{
                 text: 'Done',

diff --git a/singlecell/src/org/labkey/singlecell/run/CellRangerVDJWrapper.java b/singlecell/src/org/labkey/singlecell/run/CellRangerVDJWrapper.java
@@ -395,9 +395,6 @@ public AlignmentStep.AlignmentOutput performAlignment(Readset rs, List<File> inp
                 lockFile.delete();
             }
 
-            boolean discardBam = getProvider().getParameterByName(AbstractAlignmentStepProvider.DISCARD_BAM).extractValue(getPipelineCtx().getJob(), getProvider(), getStepIdx(), Boolean.class, false);
-            args.add("--create-bam=" + !discardBam);
-
             getWrapper().execute(args);
 
             File outdir = new File(outputDirectory, id);
@@ -490,14 +487,13 @@ private File processOutputsForType(String sampleId, Readset rs, ReferenceGenome
                 }
             }
 
-            boolean discardBam = getProvider().getParameterByName(AbstractAlignmentStepProvider.DISCARD_BAM).extractValue(getPipelineCtx().getJob(), getProvider(), getStepIdx(), Boolean.class, false);
             File bam = new File(sampleDir, "all_contig.bam");
-            if (!discardBam && !bam.exists())
+            if (!bam.exists())
             {
                 throw new PipelineJobException("Unable to find file: " + bam.getPath());
             }
 
-            if (!discardBam && isPrimaryDir)
+            if (isPrimaryDir)
             {
                 output.setBAM(bam);
             }