From 2887c38ca9ef00e37849fb4d266868c6ace4c0ec Mon Sep 17 00:00:00 2001 From: Vitalii Stefaniv Date: Wed, 25 Sep 2024 18:06:06 +0300 Subject: [PATCH 1/2] feat: added ordering to contributors list retrieving gf-533 --- .../backend/src/modules/contributors/contributor.repository.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/apps/backend/src/modules/contributors/contributor.repository.ts b/apps/backend/src/modules/contributors/contributor.repository.ts index 1d574564..96860719 100644 --- a/apps/backend/src/modules/contributors/contributor.repository.ts +++ b/apps/backend/src/modules/contributors/contributor.repository.ts @@ -125,7 +125,8 @@ class ContributorRepository implements Repository { .where("projects.id", projectId) .whereNull("contributors.hiddenAt") .groupBy("contributors.id") - .withGraphFetched("gitEmails"); + .withGraphFetched("gitEmails") + .orderBy("last_activity_date", "desc"); if (!hasHidden) { query.whereNull("contributors.hiddenAt"); From 3972a765e652c5125a7c9b8cb7368be9b0def9ac Mon Sep 17 00:00:00 2001 From: Vitalii Stefaniv Date: Wed, 25 Sep 2024 18:40:14 +0300 Subject: [PATCH 2/2] refactor: used enum for ordering direction gf-533 --- apps/backend/src/modules/contributors/contributor.repository.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/backend/src/modules/contributors/contributor.repository.ts b/apps/backend/src/modules/contributors/contributor.repository.ts index 96860719..de372c0c 100644 --- a/apps/backend/src/modules/contributors/contributor.repository.ts +++ b/apps/backend/src/modules/contributors/contributor.repository.ts @@ -126,7 +126,7 @@ class ContributorRepository implements Repository { .whereNull("contributors.hiddenAt") .groupBy("contributors.id") .withGraphFetched("gitEmails") - .orderBy("last_activity_date", "desc"); + .orderBy("last_activity_date", SortType.DESCENDING); if (!hasHidden) { query.whereNull("contributors.hiddenAt");