fix: Browser Back button not functioning after redirecting to the Analytics page from the Project details page gf-540 #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
s1rserg
commented
Sep 25, 2024
•
s1rserg
commented
- Browser Back button is now working after redirecting to the Analytics page on contributor item click.
- Added search preselected for contributor name.
- Fixed activity chart not clickable.
s1rserg
requested review from
what1s1ove,
liza-veis and
yevhenii-hladkov
as code owners
what1s1ove
approved these changes
Sep 26, 2024
liza-veis
approved these changes
Sep 26, 2024
liza-veis
reviewed
Sep 26, 2024
| @@ -20,7 +20,15 @@ const useSearchFilters = ({ | |||
| : ""; | |||
| const [search, setSearch] = useState<string>(searchParameter); | |||
|
|
|||
| const [isInitialLoad, setIsInitialLoad] = useState<boolean>(true); | |||
There was a problem hiding this comment.
Are you sure this works as expected? I was thinking maybe the problem in place where we call navigate? like there different methods for navigation, push, replace etc
There was a problem hiding this comment.
It works only for the redirection from click on contributor item to analytics page. But for example when user is on contributors page and then clicks on sidebar to get to access management page and tries to click back it doesn't go back. It appears to be related to query parameters. I'm unsure if this qualifies as a bug, as the QA team only mentioned that specific redirection in the ticket, so they may consider the current behavior acceptable for these pages.
…after-redirecting-to-the-analytics-page
GvoFor
reviewed
Sep 26, 2024
yevhenii-hladkov
approved these changes
Sep 26, 2024
This was referenced Sep 26, 2024
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.