feat: Add a loading indicator with a tick for the API Key Generation field at the Setup Analytics modal gf-189 #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perekotypole
requested review from
what1s1ove,
liza-veis and
yevhenii-hladkov
as code owners
perekotypole
commented
Sep 27, 2024
Comment on lines
+137
to
+145
| {...(isKeyGenerated | ||
| ? { | ||
| leftIcon: ( | ||
| <div className={styles["generated-key-indicator"]}> | ||
| <Icon height={20} name="check" width={20} /> | ||
| </div> | ||
| ), | ||
| } | ||
| : {})} |
There was a problem hiding this comment.
@liza-veis I'm not sure about this
leftIcon: {
isKeyGenerated ? <div className={styles["generated-key-indicator"]}>
<Icon height={20} name="check" width={20} />
</div> : <></> (or undefined)
},
The code above looks better, but it doesn't work properly. So it's a solution, but I don't like the way the code looks.
There was a problem hiding this comment.
we can use && here instead of ?, this will simplify it a bit
There was a problem hiding this comment.
@liza-veis I tried, but...
There was a problem hiding this comment.
in this case, let's leave it as it is
liza-veis
approved these changes
Sep 27, 2024
This was referenced Sep 27, 2024
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
idle view:
fulfilled view:
