fix: the delete project button is displayed and the deletion is accessible for the manage specific project permission gf-570 #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Fjortis
commented
Sep 27, 2024
Fjortis
commented
- Removed delete button showing for users with any of the Projectpermissions.
- Adjusted backend to limit deletion for users with Projectpermissions
…t group permission gf-570
…menu for clarity gf-570
Fjortis
requested review from
what1s1ove,
liza-veis and
yevhenii-hladkov
as code owners
Fjortis
changed the title
Fjortis
changed the title
liza-veis
reviewed
Sep 27, 2024
| @@ -378,8 +383,8 @@ const Project = (): JSX.Element => { | |||
| <div className={styles["project-header"]}> | |||
| <h1 className={styles["title"]}>{project.name}</h1> | |||
| <ProjectDetailsMenu | |||
| hasDeleteProjectsPermissions={hasDeleteProjectsPermissions} | |||
There was a problem hiding this comment.
to make it more consistent
Suggested change
| hasDeleteProjectsPermissions={hasDeleteProjectsPermissions} | |
| hasDeleteProjectsPermission={hasDeleteProjectsPermission} |
liza-veis
approved these changes
Sep 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.