Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OV-311: Save video draft #343

Merged
merged 35 commits into from
Sep 20, 2024
Merged

OV-311: Save video draft #343

merged 35 commits into from
Sep 20, 2024

Conversation

Sanchousina
Copy link
Collaborator

In this pr:

  • User can save video draft
  • User can see when he made new changes that are not saved
  • User is shown a notification for video save
  • User is not allowed to save video that doesn't have at least 1 scene with an avatar and 1 script
  • Video record is created on the first save and is updated on the next saves
  • When the user submits a video for rendering, if it was saved previously - the video record updates, if not - a new video record is created.
  • Use preview url for video thumbnails
  • If the user changes the first scene avatar after saving the video, on the next save the preview url is updated as well
save.video.draft.mp4

@Sanchousina
OV-311: * change submit button to dropdown
f5207db
@Sanchousina
Merge remote-tracking branch 'origin/next' into task/OV-311-save-vide…
6db3aa8 
…o-draft
@Sanchousina
OV-311: * fix button style
b81a133
@Sanchousina
Merge remote-tracking branch 'origin/next' into task/OV-311-save-vide…
24882b7 
…o-draft
@Sanchousina
OV-311: * add is draft saved state to store
e0dcb63
@Sanchousina
OV-311: * add handle save draft
65ac2f4
@Sanchousina
OV-311: + video draft middleware
a174bab
@Sanchousina
OV-311: * show unsaved changes with *
7487420
@Sanchousina
Merge remote-tracking branch 'origin/task/OV-298-modify-avatar-render…
42b36e3 
…-controller-for-composition-use' into task/OV-311-save-video-draft
@Sanchousina
OV-311: * add save video method to video-api
6439f92
@Sanchousina
Merge remote-tracking branch 'origin/task/OV-298-modify-avatar-render…
6385079 
…-controller-for-composition-use' into task/OV-311-save-video-draft
@Sanchousina
OV-311: * add action for saving video
58d468a
@Sanchousina
OV-311: * save video draft
03186c3
@Sanchousina
OV-311: * movde video-api to common
a441dfc
@Sanchousina
OV-311: * if video was already saved - update it
9b22016
@Sanchousina
OV-311: * show warning if missing data for saving video
11a50c8
@Sanchousina
OV-311: * reduce repetetive code
6ec05fc
@Sanchousina
OV-311: * set isDraftSaved when updating video
77f992c
@Sanchousina
OV-311: * when rendering video - create or update video
53fcc3e
@Sanchousina
OV-311: * use preview url for videos thumbnail
24d5376
@Sanchousina
OV-311: * fix logic with * near video name
6c2fc54
@Sanchousina
OV-311: * add notifications for save video
ff76807
@Sanchousina
OV-311: * update preview when video updates
1eb1330
@Sanchousina
Merge remote-tracking branch 'origin/next' into task/OV-311-save-vide…
60f3156 
…o-draft
@Sanchousina Sanchousina added the FE Fronted feature label Sep 18, 2024
@Sanchousina Sanchousina added this to the Final DEMO milestone Sep 18, 2024
@Sanchousina Sanchousina self-assigned this Sep 18, 2024
@Sanchousina Sanchousina linked an issue Sep 18, 2024 that may be closed by this pull request
FEAT: Save video draft #311
Closed
This was referenced Sep 18, 2024
Open
Closed
@Sanchousina Sanchousina mentioned this pull request Sep 19, 2024
Merged
sergiy4
sergiy4 previously approved these changes Sep 19, 2024
View reviewed changes
@nikita-remeslov
Merge pull request #361 from BinaryStudioAcademy/task/OV-351-add-dele…
f4ac1b4 
…te-button-on-draft-videos

OV-351: Add delete button on draft videos
@nikita-remeslov nikita-remeslov merged commit 5b87517 into next Sep 20, 2024
2 checks passed
@nikita-remeslov nikita-remeslov deleted the task/OV-311-save-video-draft branch September 20, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikita-remeslov nikita-remeslov nikita-remeslov approved these changes

@sergiy4 sergiy4 sergiy4 left review comments

@anton-otroshchenko anton-otroshchenko Awaiting requested review from anton-otroshchenko anton-otroshchenko is a code owner

@sofiia-trokhymchuk sofiia-trokhymchuk Awaiting requested review from sofiia-trokhymchuk sofiia-trokhymchuk is a code owner

Assignees

@Sanchousina Sanchousina

Labels
FE Fronted feature
Projects
bsa-2024-outreachvids
Status: To Be Tested
Milestone
Final DEMO
Development

Successfully merging this pull request may close these issues.

FEAT: Save video draft
6 participants
@Sanchousina @nikita-remeslov @sergiy4 @anton-otroshchenko @sofiia-trokhymchuk @stefano-lacorazza