OV-352: Add logic for edit video button #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sanchousina
requested review from
nikita-remeslov,
anton-otroshchenko and
sofiia-trokhymchuk
as code owners
4 tasks
…c-for-edit-video-button
sofiia-trokhymchuk
requested changes
Sep 19, 2024
| @@ -39,13 +36,12 @@ class VideoRepository implements Repository { | |||
| .insert({ | |||
| userId, | |||
| name, | |||
| composition, | |||
| composition: composition, | |||
There was a problem hiding this comment.
Why can't you use just composition?
There was a problem hiding this comment.
Why delete empty lines everywhere? :)
| @@ -59,7 +59,7 @@ class VideoService implements Service { | |||
| const video = await this.videoRepository.create( | |||
| VideoEntity.initializeNew({ | |||
| name: payload.name, | |||
| composition: JSON.stringify(payload.composition), | |||
| composition: payload.composition, | |||
| previewUrl: payload.composition?.scenes[0]?.avatar?.url || '', | |||
There was a problem hiding this comment.
Suggested change
| previewUrl: payload.composition?.scenes[0]?.avatar?.url || '', | |
| previewUrl: payload.composition?.scenes[0]?.avatar?.url ?? '', |
…c-for-edit-video-button
…-for-edit-video-button
nikita-remeslov
approved these changes
Sep 20, 2024
nikita-remeslov
deleted the
task/OV-352-add-logic-for-edit-video-button
branch
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on OV-311
In this pr:
When user clicks on edit video button, the studio page opens with loaded video data.
edit.video.button.mp4