OV-349: Add warning modal when the scenes exceed the scripts #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefano-lacorazza
requested review from
nikita-remeslov,
anton-otroshchenko and
sofiia-trokhymchuk
as code owners
6 tasks
anton-otroshchenko
requested changes
Sep 23, 2024
| const scenesExceedScripts = (scenes: Scene[], scripts: Script[]): boolean => { | ||
| const totalScenesDuration = scenes.reduce( | ||
| (accumulator, scene) => accumulator + scene.duration, | ||
| 0, |
There was a problem hiding this comment.
lets prevent magic values
| ); | ||
| const totalScriptsDuration = scripts.reduce( | ||
| (accumulator, script) => accumulator + script.duration, | ||
| 0, |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a check in the submit function to compare the total duration of the scenes with the duration of the scripts.
If the scenes duration exceeds the scripts duration, the modal is opened.
Otherwise, the submission proceeds as usual.
OutreachVids.-.Google.Chrome.2024-09-20.17-05-55.mp4
OutreachVids.-.Google.Chrome.2024-09-20.17-06-36.mp4