Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

frontend/btcdirect: enable write clipboard for iframe integration #3197

Merged
merged 1 commit into from
Feb 24, 2025
Merged

frontend/btcdirect: enable write clipboard for iframe integration #3197

merged 1 commit into from
Feb 24, 2025

Conversation

Beerosagos
Copy link
Collaborator

This fixes the broken copy button in the bank transfer page.

Before asking for reviews, here is a check list of the most common things you might need to consider:

  • updating the Changelog
  • writing unit tests
  • checking if your changes affect other coins or tokens in unintended ways
  • testing on multiple environments (Qt, Android, ...)
  • having an AI review your changes

@Beerosagos
frontend/btcdirect: enable write clipboard for iframe integration
31486d2 
This fixes the broken copy button in the bank transfer page.
@Beerosagos Beerosagos marked this pull request as ready for review February 24, 2025 15:49
sutterseba
sutterseba approved these changes Feb 24, 2025
View reviewed changes
Copy link
Collaborator

@sutterseba sutterseba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on macOS

thisconnect
thisconnect approved these changes Feb 24, 2025
View reviewed changes
Copy link
Collaborator

@thisconnect thisconnect left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested Android LGTM

@Beerosagos Beerosagos merged commit 85995bc into BitBoxSwiss:release-v4.47.0 Feb 24, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisconnect thisconnect thisconnect approved these changes

@sutterseba sutterseba sutterseba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Beerosagos @thisconnect @sutterseba