frontend: always show manage-device in settings menu #3199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisconnect
force-pushed
the
frontend-always-show-device-settings
branch
2 times, most recently
from
33a9378 to
acd7cbe
Compare
benma
approved these changes
Feb 26, 2025
| import { ManageDeviceGuide } from './bitbox02/settings-guide'; | ||
| import styles from './no-device-connected.module.css'; | ||
|
|
||
| type TProps = { |
There was a problem hiding this comment.
use TPagePropsWithSettingsTabs?
There was a problem hiding this comment.
good catch thanks
Conditionally hiding navigation items is not ideal and can be confusing. Another reason to always show 'Manage device' but with 'No device connected' is to have a place to add detect-bitbox button. With this change the app will route into device settings if the user unlocks on no-connected-device route. It does not cover showing no-connected-device again after the user unplugs, reason is that with rememeber-wallets this should go to account-summary and without go to waiting for device. There was no clean way to detect and route back to no-connected-device. Ideally the 'Manage accounts' item is also always shown in settings navigation, which can be done in another commit.
Ensure the "Manage Accounts" navigation item is always visible, even when no accounts are present. Consistently displaying navigation items improves usability and prevents confusion caused by conditional visibility.
thisconnect
force-pushed
the
frontend-always-show-device-settings
branch
from
43d7f5b to
a9f8348
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conditionally hiding navigation items is not ideal and can be confusing.
Another reason to always show 'Manage device' but with 'No device connected' is to have a place to add detect-bitbox button.
With this change the app will route into device settings if the user unlocks on no-connected-device route.
It does not cover showing no-connected-device again after the user unplugs, reason is that with rememeber-wallets this should go to account-summary and without go to waiting for device. There was no clean way to detect and route back to no-connected-device.
Ideally the 'Manage accounts' item is also always shown in settings navigation, which can be done in another commit.
Before asking for reviews, here is a check list of the most common things you might need to consider: