Don't complain about "%d%%" being exposed for translation

This is fine, as translators can move the %% to the front
Blake-Madden · Jan 5, 2025 · d2ee6c5 · d2ee6c5
1 parent aec711c
commit d2ee6c5
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/src/i18n_review.cpp b/src/i18n_review.cpp
@@ -2281,6 +2281,11 @@ namespace i18n_check
                 }
             }
         string_util::trim(strToReview);
+        // something like "%d%%" should be translatable
+        if (strToReview == L"%%")
+            {
+            return std::make_pair(false, strToReview.length());
+            }
 
         try
             {

diff --git a/tests/i18nstringtests.cpp b/tests/i18nstringtests.cpp
@@ -81,6 +81,7 @@ TEST_CASE("untranslatable", "[i18nreview]")
     CHECK_FALSE(reviewer.is_untranslatable_string(L"100%", false).first);
     CHECK_FALSE(reviewer.is_untranslatable_string(L"{n}%", false).first);
     CHECK_FALSE(reviewer.is_untranslatable_string(L"%d%", false).first);
+    CHECK_FALSE(reviewer.is_untranslatable_string(L"%d%%", false).first);
     // HTML anchors
     CHECK(reviewer.is_untranslatable_string(L"#something", false).first);
     CHECK(reviewer.is_untranslatable_string(L"#Something-else", false).first);