fix(locale): align language handling with IDE settings (fixes #308) #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use IDE locale instead of system default for language displays - Implement Collator-based sorting for locale list - Standardize prompt locale to 'English name (code) – Native name'
Blarc
requested changes
Feb 16, 2025
src/main/kotlin/com/github/blarc/ai/commits/intellij/plugin/AICommitsUtils.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/github/blarc/ai/commits/intellij/plugin/AICommitsUtils.kt
Outdated
Show resolved
Hide resolved
...ain/kotlin/com/github/blarc/ai/commits/intellij/plugin/settings/AICommitsListCellRenderer.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/github/blarc/ai/commits/intellij/plugin/settings/AppSettingsConfigurable.kt
Show resolved
Hide resolved
…larc#309) - Simplify locale display format in prompts to use English language names - Remove redundant Elvis operator in locale retrieval - Replace deprecated Locale constructor with forLanguageTag() - Add collator comments explaining locale-aware sorting rationale - Include contextual help about language display differences
|
This looks great @Canario5, thank you so much! 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #308 - Improved locale handling for non-English IDE configurations
Changes: