Skip to content
This repository was archived by the owner on Feb 26, 2025. It is now read-only.

Commit

Permalink
Fix home icon/sub app icons. (#661)
Browse files Browse the repository at this point in the history
- Remove home icon.
- Side bar icons will always take user to the subapp landing page.
  • Loading branch information
Dhanesh Neela Mana authored Aug 17, 2020
1 parent ee6aa1f commit 6144a28
Show file tree
Hide file tree
Showing 6 changed files with 0 additions and 29 deletions.
3 changes: 0 additions & 3 deletions src/shared/containers/ResourceViewContainer.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import ResourceActionsContainer from '../containers/ResourceActionsContainer';
import ResourceEditorContainer from '../containers/ResourceEditor';
import SchemaLinkContainer from '../containers/SchemaLink';
import GraphContainer from '../containers/GraphContainer';
import HomeIcon from '../../subapps/admin/components/HomeIcon';
import ResourceMetadata from '../components/ResourceMetadata';
import ResourcePlugins from './ResourcePlugins';
import usePlugins from '../hooks/usePlugins';
Expand Down Expand Up @@ -266,8 +265,6 @@ const ResourceViewContainer: React.FunctionComponent<{
{!!resource && !!latestResource && !error && (
<>
<h1 className="name">
<HomeIcon />
{' | '}
<span>
<a onClick={() => goToOrg(orgLabel)}>{orgLabel}</a> |{' '}
<a onClick={() => goToProject(orgLabel, projectLabel)}>
Expand Down
4 changes: 0 additions & 4 deletions src/shared/layouts/FusionMainLayout.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -104,10 +104,6 @@ const FusionMainLayout: React.FC<FusionMainLayoutProps> = ({
const item = subApps.find(subApp => subApp.key === data.key);
setSelectedItem(item as SubAppProps);
if (item) {
if (`/${location.pathname.split('/')[1]}` === item.route) {
// already in the subApp, don't change location
return;
}
goTo(item.route);
}
};
Expand Down
13 changes: 0 additions & 13 deletions src/subapps/admin/components/HomeIcon/index.tsx

This file was deleted.

3 changes: 0 additions & 3 deletions src/subapps/admin/views/ElasticSearchQueryView.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import { useNexusContext } from '@bbp/react-nexus';

import ViewStatisticsProgress from '../components/Views/ViewStatisticsProgress';
import ElasticSearchQueryContainer from '../containers/ElasticSearchQuery';
import HomeIcon from '../components/HomeIcon';
import { getResourceLabel, labelOf } from '../../../shared/utils';
import { useAdminSubappContext } from '..';

Expand Down Expand Up @@ -80,8 +79,6 @@ const ElasticSearchQueryView: React.FunctionComponent = (): JSX.Element => {
<div className="label">
<h1 className="name">
<span>
<HomeIcon />
{' | '}
<Link to={`/${namespace}/${orgLabel}`}>{orgLabel}</Link>
{' | '}
<Link to={`/${namespace}/${orgLabel}/${projectLabel}`}>
Expand Down
3 changes: 0 additions & 3 deletions src/subapps/admin/views/ProjectView.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ import { Link } from 'react-router-dom';

import ViewStatisticsContainer from '../components/Views/ViewStatisticsProgress';
import ResourceListBoardContainer from '../../../shared/containers/ResourceListBoardContainer';
import HomeIcon from '../components/HomeIcon';
import ProjectTools from '../components/Projects/ProjectTools';
import { useAdminSubappContext } from '..';

Expand Down Expand Up @@ -75,8 +74,6 @@ const ProjectView: React.FunctionComponent = () => {
<div className="project-banner">
<div className="label">
<h1 className="name">
<HomeIcon />
{' | '}
<span>
<Link to={`/admin/${orgLabel}`}>{orgLabel}</Link>
{' | '}
Expand Down
3 changes: 0 additions & 3 deletions src/subapps/admin/views/SparqlQueryView.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import { useNexusContext } from '@bbp/react-nexus';

import ViewStatisticsProgress from '../components/Views/ViewStatisticsProgress';
import SparqlQueryContainer from '../containers/SparqlQuery';
import HomeIcon from '../components/HomeIcon';
import { getResourceLabel, labelOf } from '../../../shared/utils';
import { useAdminSubappContext } from '..';

Expand Down Expand Up @@ -75,8 +74,6 @@ const SparqlQueryView: React.FunctionComponent = (): JSX.Element => {
<div className="label">
<h1 className="name">
<span>
<HomeIcon />
{' | '}
<Link to={`/${namespace}/${orgLabel}`}>{orgLabel}</Link>
{' | '}
<Link to={`/${namespace}/${orgLabel}/${projectLabel}`}>
Expand Down

0 comments on commit 6144a28

Please sign in to comment.