This repository was archived by the owner on Feb 26, 2025. It is now read-only.
4641 // Pin history version to fix issue with opening ids with encoded characters #1478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dinika
force-pushed
the
4641/use-different-history-version
branch
from
4f651c6 to
54e56a5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1478 +/- ##
========================================
Coverage 47.89% 47.89%
========================================
Files 250 250
Lines 11474 11474
Branches 2696 2696
========================================
Hits 5495 5495
Misses 5946 5946
Partials 33 33 ☔ View full report in Codecov by Sentry. |
automatically decoded This is a temporary solution until we update react-router to v6 If a nexus id has some encoded chars (like - https://hello.lol/https%3A%2F%2Fencoded.url%2Fwow), history.push pushes this to window.location: https%3A%2F%2Fhello.lol%2Fhttps%3A%2F%2Fencoded.url%2Fwow instead of: https%3A%2F%2Fhello.lol%2Fhttps%253A%252F%252Fencoded.url%252Fwow Using an older version of `history` and forcing all fusion dependencies to use this version is working for now. This solution is taken from remix-run/history#505 (comment) Signed-off-by: Dinika Saxena <dinikasaxenas@gmail.com>
Dinika
force-pushed
the
4641/use-different-history-version
branch
from
1957584 to
df80ffb
Compare
|
nice @Dinika 👍 |
bilalesi
approved these changes
Jan 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4641
Description
This is meant to be a temporary solution until we update react-router to v6 (where the following issue is fixed with some caveats).
If a resource id has some encoded chars (like - https://hello.lol/https%3A%2F%2Fencoded.url%2Fwow),
history.pushpushes this to window.location:instead of:
Using an older version of
historyand forcing all fusion dependencies to use this version is working for now.I tried pinning version
4.7of history but that didn't work.This solution is taken from remix-run/history#505 (comment)
Thanks to @bilalesi for sharing the solution
How to test this PR
Run
yarnto install the older version ofhistoryWith fusion using dev version of nexus, try going to http://localhost:8000/copies/sscx/resources/https%3A%2F%2Fdev.nise.bbp.epfl.ch%2Fnexus%2Fv1%2Fresources%2Fcopies%2Fsscx%2F_%2F1bd3d9a5-7533-4033-b575-1823862c7b8c This should work
If you search for the above resource in MyData or Data-Explorer or project listing views and click on its row, then it should open the resource container with the right resource instead of showing an error.
Types of changes
Checklist: