This repository was archived by the owner on Feb 26, 2025. It is now read-only.
Download of resources with tags in their ids should work #1505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, just need cleaning the logs. |
bilalesi
approved these changes
Feb 21, 2024
When storing these resources and their distributions to the localstorage the tag should be stored as well. Otherwise the `key` (required to add/remove items from data panel) is inconsistent, leading to bugs (example, adding the resource works, but removing them from the data panel does not, because the id is not the same). Signed-off-by: Dinika Saxena <dinikasaxenas@gmail.com>
Dinika
force-pushed
the
fix-swc-file-shown-twice
branch
from
8b7ac34 to
84a16a9
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1505 +/- ##
===========================================
- Coverage 48.13% 48.12% -0.02%
===========================================
Files 251 251
Lines 11553 11560 +7
Branches 2709 2709
===========================================
+ Hits 5561 5563 +2
- Misses 5958 5963 +5
Partials 34 34 ☔ View full report in Codecov by Sentry. |
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When storing these resources and their distributions to the localstorage the tag should be stored as well. Otherwise the
key(required to add/remove items from data panel) is inconsistent, leading to bugs (example, adding the resource works, but removing them from the data panel does not, because the id is not the same).Fixes #
Description
How has this been tested?
Types of changes
Checklist: