Skip to content
This repository was archived by the owner on Feb 26, 2025. It is now read-only.

Download of resources with tags in their ids should work #1508

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

Dinika
Copy link
Contributor

@Dinika Dinika commented Feb 22, 2024

Same as this PR but rebased on migration-merge branch.

How to test

  1. Start frontend pointing to delta prod
  2. Go to this resource locally
  3. Add 2 resources to data download - this should work
  4. Remove one resource - data panel should update (this is the part that was broken)

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added necessary unit and integration tests.
  • I have added screenshots (if applicable), in the comment section.

When storing these resources and their distributions to the localstorage
the tag should be stored as well. Otherwise the `key` (required to
add/remove items from data panel) is inconsistent, leading to bugs
(example, adding the resource works, but removing them from the data
panel does not, because the id is not the same).

Signed-off-by: Dinika Saxena <dinikasaxenas@gmail.com>
Base automatically changed from fix-studio-and-workspace-edits to migration-merge February 22, 2024 09:28
@Dinika Dinika merged commit 5e83b58 into migration-merge Feb 22, 2024
4 of 5 checks passed
@Dinika Dinika deleted the fix-swc-file-shown-twice branch February 22, 2024 09:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants