Skip to content
This repository was archived by the owner on Feb 26, 2025. It is now read-only.

Use backslashes in file paths for windows #1511

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Conversation

Dinika
Copy link
Contributor

@Dinika Dinika commented Feb 22, 2024

The download should keep working on mac and linux. I want to deploy (to dev at least) this PR to check if it will also work on windows. I am having some issues setting up a windows VM.

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added necessary unit and integration tests.
  • I have added screenshots (if applicable), in the comment section.

Copy link
Contributor

@bilalesi bilalesi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one @Dinika 👍 , let's give it a try on dev

@Dinika Dinika merged commit 5516c0d into develop Feb 22, 2024
1 check passed
@Dinika Dinika deleted the data-download-on-windows branch February 22, 2024 16:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants