refactor: relay command review (#64)

changes:
- changed `Action<object?>` to `Action`
- changed `Predicate<object?>?` to `Func<bool>?`
- small refactoring

closes #63

Author: BoBoBaSs84

src/BB84.Notifications/RelayCommand.cs

@@ -12,25 +12,25 @@ namespace BB84.Notifications;
 /// </remarks>
 /// <param name="execute">The action to execute.</param>
 /// <param name="canExecute">The condition to execute.</param>
-public sealed class RelayCommand(Action<object?> execute, Predicate<object?>? canExecute) : IRelayCommand
+public sealed class RelayCommand(Action execute, Func<bool>? canExecute) : IRelayCommand
 {
   /// <summary>
   /// Initializes a new instance of the <see cref="RelayCommand"/> class that can always execute.
   /// </summary>
   /// <param name="execute">The action to execute.</param>
-  public RelayCommand(Action<object?> execute) : this(execute, null)
+  public RelayCommand(Action execute) : this(execute, null)
   { }
 
   /// <inheritdoc/>
   public event EventHandler? CanExecuteChanged;
 
   /// <inheritdoc/>
   public bool CanExecute(object? parameter)
-    => canExecute is null || canExecute.Invoke(parameter);
+    => canExecute is null || canExecute.Invoke();
 
   /// <inheritdoc/>
   public void Execute(object? parameter)
-    => execute.Invoke(parameter);
+    => execute.Invoke();
 
   /// <inheritdoc/>
   public void NotifyCanExecuteChanged()
@@ -48,7 +48,7 @@ public void NotifyCanExecuteChanged()
 /// <typeparam name="T">The type to wor with</typeparam>
 /// <param name="execute">The action to execute.</param>
 /// <param name="canExecute">The condition to execute.</param>
-public sealed class RelayCommand<T>(Action<T> execute, Predicate<T>? canExecute) : IRelayCommand<T>
+public sealed class RelayCommand<T>(Action<T> execute, Func<T, bool>? canExecute) : IRelayCommand<T>
 {
   /// <summary>
   /// Initializes a new instance of <see cref="RelayCommand{T}"/> class that can always execute.

tests/BB84.NotificationsTests/Attributes/NotifyChangedAttributeTests.cs

@@ -9,7 +9,7 @@ public class NotifyChangedAttributeTests
   [TestMethod]
   public void NotifyChangedAttributeTest()
   {
-    List<string> propertiesNotified = new();
+    List<string> propertiesNotified = [];
     TestClass testClass = new(3, 40);
     testClass.PropertyChanged += (sender, e) => propertiesNotified.Add(e.PropertyName!);
 

tests/BB84.NotificationsTests/Attributes/NotifyChangingAttributeTests.cs

@@ -9,7 +9,7 @@ public class NotifyChangingAttributeTests
   [TestMethod]
   public void NotifyChangingAttributeTest()
   {
-    List<string> propertiesNotified = new();
+    List<string> propertiesNotified = [];
     TestClass testClass = new(3, 40);
     testClass.PropertyChanging += (sender, e) => propertiesNotified.Add(e.PropertyName!);
 

tests/BB84.NotificationsTests/BindablePropertyTests.cs

@@ -6,11 +6,8 @@ namespace BB84.NotificationsTests;
 [TestClass]
 public sealed partial class BindablePropertyTests
 {
-  private sealed class TestClass
+  private sealed class TestClass(int bindableProperty)
   {
-    public TestClass(int bindableProperty)
-      => BindableProperty = new BindableProperty<int>(bindableProperty);
-
-    public IBindableProperty<int> BindableProperty { get; set; }
+    public IBindableProperty<int> BindableProperty { get; set; } = new BindableProperty<int>(bindableProperty);
   }
 }

tests/BB84.NotificationsTests/NotificationCollectionTests.cs

@@ -16,7 +16,7 @@ private sealed class MyCollection : NotificationCollection, ICollection<string>
     private readonly Collection<string> _collection;
 
     public MyCollection()
-      => _collection = new Collection<string>();
+      => _collection = [];
 
     public int Count => _collection.Count;
     public bool IsReadOnly => false;

tests/BB84.NotificationsTests/RelayCommandTests.cs

@@ -20,10 +20,10 @@ public TestClass()
     }
 
     public IRelayCommand Command
-      => _command ??= new RelayCommand(x => CommandExecution++);
+      => _command ??= new RelayCommand(() => CommandExecution++);
 
     public IRelayCommand CondCommand
-      => _condCommand ??= new RelayCommand(x => CommandExecution++, x => false);
+      => _condCommand ??= new RelayCommand(() => CommandExecution++, () => false);
 
     public IRelayCommand<int> IntCommand
       => _intCommand ??= new RelayCommand<int>(x => IntegerCommandExecution = x);