Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Typo in extension methods #107

Closed
BoBoBaSs84 opened this issue Jun 4, 2024 · 0 comments · Fixed by #108
Closed

Fix: Typo in extension methods #107

BoBoBaSs84 opened this issue Jun 4, 2024 · 0 comments · Fixed by #108
Assignees
@BoBoBaSs84
Labels
invalid This doesn't seem right refactoring Improvements or additions to the code quality

Comments

@BoBoBaSs84
Copy link
Owner

Describe the bug
The method ToSaveVoid() should be named ToSafeVoid().

To Reproduce
See the code.
@BoBoBaSs84 BoBoBaSs84 added invalid This doesn't seem right refactoring Improvements or additions to the code quality labels Jun 4, 2024
@BoBoBaSs84 BoBoBaSs84 self-assigned this Jun 4, 2024
BoBoBaSs84 added a commit that referenced this issue Jun 4, 2024
@BoBoBaSs84
fix: typo in extension methods
b99e542 
changes:
- renamed the method to `FireAndForgetSafeAsync`
- added some unit testing

closes #107
@BoBoBaSs84 BoBoBaSs84 mentioned this issue Jun 4, 2024
Merged
@BoBoBaSs84 BoBoBaSs84 linked a pull request Jun 4, 2024 that will close this issue
fix: typo in extension methods #108
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BoBoBaSs84 BoBoBaSs84

Labels
invalid This doesn't seem right refactoring Improvements or additions to the code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: typo in extension methods BoBoBaSs84/BB84.Notifications
1 participant
@BoBoBaSs84