Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Interface and class naming #76

Closed
BoBoBaSs84 opened this issue Mar 25, 2024 · 0 comments · Fixed by #77
Closed

Refactor: Interface and class naming #76

BoBoBaSs84 opened this issue Mar 25, 2024 · 0 comments · Fixed by #77
Assignees
@BoBoBaSs84
Labels
breaking New feature or request would lead into a breaking change feature New feature or request

Comments

@BoBoBaSs84
Copy link
Owner

Is your feature request related to a problem? Please describe.
The request comes more from the direction of providing more clarity.

Describe the solution you'd like
Interfaces and their implementations should have the prefix Notifiable instead of Notification.

Describe alternatives you've considered
None. Different package maybe, but no.

Additional context
Rename NotificationObject into NotifiableObject and so on ..
@BoBoBaSs84 BoBoBaSs84 added feature New feature or request breaking New feature or request would lead into a breaking change labels Mar 25, 2024
@BoBoBaSs84 BoBoBaSs84 self-assigned this Mar 25, 2024
BoBoBaSs84 added a commit that referenced this issue Mar 25, 2024
@BoBoBaSs84
refac: interface and class naming
face717 
changes:
- renamed all the interfaces
- renamed all the implementations
- renamed all the unit tests
- improved comments
- added new constructors

closes #76
@BoBoBaSs84 BoBoBaSs84 mentioned this issue Mar 25, 2024
Merged
@BoBoBaSs84 BoBoBaSs84 linked a pull request Mar 25, 2024 that will close this issue
refactor: interface and class naming #77
Merged
BoBoBaSs84 added a commit that referenced this issue Mar 25, 2024
@BoBoBaSs84
refactor: interface and class naming (#77)
e7d6da6 
changes:
- renamed all the interfaces
- renamed all the implementations
- renamed all the unit tests
- improved comments
- added new constructors

closes #76
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BoBoBaSs84 BoBoBaSs84

Labels
breaking New feature or request would lead into a breaking change feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: interface and class naming BoBoBaSs84/BB84.Notifications
1 participant
@BoBoBaSs84