Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): Update deasync to 0.1.27 #46

Closed
wants to merge 1 commit into from
Closed

Conversation

KaiPrince
Copy link

US140756: [awards-ui] Configure awards-ui repo with Dependabot and update dependencies

Related issue: #45

@KaiPrince KaiPrince requested a review from a team July 19, 2022 18:42
@KaiPrince
Copy link
Author

I didn't include a lockfile because there wasn't already one present. But should there be?

@mbardakovD2L
Copy link

I didn't include a lockfile because there wasn't already one present. But should there be?

I would keep it as-is, I think whether or not there is a lockfile has to do with what version of node/npm this repo uses and updating that is probably out of scope for a single dependency

@lloydwaddell
Copy link

this is consistent with previous dependency updates in the repo
1cdef76

@KaiPrince KaiPrince changed the title Update deasync to 0.1.27 fix(deps): Update deasync to 0.1.27 Jul 19, 2022
@AntonBazhal
Copy link

TL;DR; do not add lockfile n this PR

Lockfiles do not matter much for libraries. npm only uses a project's lockfile and discards the ones that come from dependencies. So a lockfile here matters for dev experience only.

@bearfriend
Copy link

I'm confused about what this is effectively doing. ^0.1 will already match 0.1.27. We try not to use more specific versions than are necessary.

@KaiPrince
Copy link
Author

It is required by https://github.com/Brightspace/awards-ui/pull/90

@KaiPrince
Copy link
Author

Closing because this is not necessary it turns out

@KaiPrince KaiPrince closed this Jul 21, 2022
@KaiPrince KaiPrince deleted the kprince/update-deasync branch July 21, 2022 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants