-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alternate implementation of common resource API #210
Conversation
What would happen if their component required both their own terms as well as the common ones? Would the terms be in different sets, and if that's the case, would |
This is kind of already an issue today when multiple mixins need localization -- although we've definitely had some bugs crop up there as the order of the mixins matters. So yeah, it'd be nice to not compound that problem. Another option would be to still just leverage |
Closing this for now, as we'll proceed with the approach #208. If later we decide to change our mind to something more along the lines of what's in this PR, it should be easy to switch |
This is an alternate implementation of #208 that uses a
LocalizeCommon
localizer class instead of merging the common resources with the rest.I feel like this is a bit cleaner, but would require the creation of a
LocalizeCommonMixin
in core that consuming components extend.Thoughts?