fix: login attempts keeps counting even after account is blocked #39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request to
brints-estate-api
includes changes to improve the handling of user login attempts and blocking logic. The most important changes include adding a return statement to prevent further processing when a user is blocked and resetting the login attempt count upon successful login.Improvements to login attempt handling:
brints-estate-api/src/auth/providers/login-user.provider.ts
: Added a return statement to exit the function early if the user is currently blocked to prevent any further processing.Enhancements to blocking logic:
brints-estate-api/src/login-attempts/providers/login-attempts.provider.ts
: Reset thelogin_attempts
count to 0 when the user's block status is reset.Code consistency:
brints-estate-api/src/login-attempts/providers/login-attempts.provider.ts
: Added a missing save operation for the user repository to ensure the user's state is consistently updated.