Import citizen types from the BIC file #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomWerner
force-pushed
the
twrner/load-citizen-types
branch
8 times, most recently
from
94fde8d to
b64b970
Compare
KulkoBSW
reviewed
Feb 15, 2025
TomWerner
force-pushed
the
twrner/load-citizen-types
branch
from
b64b970 to
90c2561
Compare
This allows us to know about things like entertainers, tax collectors, etc. While here I noticed that one of the tests wasn't actually doing anything, so I fixed the path issue and added an assertion to catch similar issues in the future. #541
TomWerner
force-pushed
the
twrner/load-citizen-types
branch
from
90c2561 to
7f0e063
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to know about things like entertainers, tax collectors, etc.
While here I noticed that one of the tests wasn't actually doing anything, so I fixed the path issue and added an assertion to catch similar issues in the future.
#541