Skip to content

missing dependencies #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dwr-psandhu opened this issue Feb 28, 2023 · 5 comments
Open

missing dependencies #28

dwr-psandhu opened this issue Feb 28, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@dwr-psandhu
Copy link
Contributor

  • schimpy version: 1.4.3
  • Python version: 3.9
  • Operating System: windows

Description

Dependencies not specified fully in setup.py

What I Did

pip install schimpy

then

import schimpy
from schimpy import schism_mesh
@dwr-psandhu
Copy link
Contributor Author

So far
rtree and gdal are missing.

These show up with the above imports

@kjnam
Copy link
Member

kjnam commented Feb 28, 2023

It is a known issue, and it will be resolved while we are upgrading dependencies. The current dependencies settings are outdated.

@kjnam kjnam added the bug Something isn't working label Jun 16, 2023
@water-e
Copy link
Contributor

water-e commented Jul 20, 2023

We've re-done the depenencies. I do see direct imports of rtree. Could that have slipped through the cracks, perhaps because it is included with other packages indirectly (I think we shouldn't rely on that for our own direct imports). I'd like to close out the issue unless there is a complication. Any issue with just adding rtree to setup.py?

@kjnam
Copy link
Member

kjnam commented Jul 20, 2023

@water-e I need to look into it. We are moving a similar RTree that Shapely v2 uses, so it is removed from the dependency list.

@dwr-psandhu
Copy link
Contributor Author

one more missing dependency while we are at it.
dms-datastore is imported in batch_metrics.py but is not listed in setup.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants