Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Field Highlighting in Error Handling for Bulk Upload #8471

Merged
merged 4 commits into from
Feb 12, 2025
Merged

Update Field Highlighting in Error Handling for Bulk Upload #8471

merged 4 commits into from
Feb 12, 2025

Conversation

bobbywells52
Copy link
Collaborator

@bobbywells52 bobbywells52 commented Feb 4, 2025 •
edited
Loading

FRONTEND PULL REQUEST

Related Issue

Changes Proposed

  • Update regex to target the header of the column in question, instead of the original logic that only target strings with an underscore.

Testing

Screenshots / Demos

  • Current Behavior:

385361281-24eaacd5-7bc5-4138-b3b6-6d1207b5a2e9

  • Updated Behavior:
Screenshot 2025-02-11 at 2 26 37 PM

@bobbywells52 bobbywells52 changed the title update regex Update Filed Highlighting in Error Handling for Bulk Upload Feb 5, 2025
@bobbywells52 bobbywells52 changed the title Update Filed Highlighting in Error Handling for Bulk Upload Update Field Highlighting in Error Handling for Bulk Upload Feb 5, 2025
@bobbywells52 bobbywells52 marked this pull request as ready for review February 11, 2025 21:31
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

mpbrown
mpbrown approved these changes Feb 12, 2025
View reviewed changes
Copy link
Collaborator

@mpbrown mpbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I had to update the spreadsheet for the chlamydia device code so linking that here
test_results_example_10-3-2022 (9).csv

Also tested that it highlights the other single word column headers and doesn't highlight "pregnant" if it is referring to it as the value. Nice work Bobby!
image

emyl3
emyl3 approved these changes Feb 12, 2025
View reviewed changes
Copy link
Collaborator

@emyl3 emyl3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bobbywells52 bobbywells52 added this pull request to the merge queue Feb 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 12, 2025
@bobbywells52 bobbywells52 added this pull request to the merge queue Feb 12, 2025
Merged via the queue into main with commit 7d1f58c Feb 12, 2025
43 checks passed
@bobbywells52 bobbywells52 deleted the bobby/8278 branch February 12, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emyl3 emyl3 emyl3 approved these changes

@mpbrown mpbrown mpbrown approved these changes

@mehansen mehansen Awaiting requested review from mehansen

@DanielSass DanielSass Awaiting requested review from DanielSass

@arinkulshi-skylight arinkulshi-skylight Awaiting requested review from arinkulshi-skylight

@DavidMcClatchey DavidMcClatchey Awaiting requested review from DavidMcClatchey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Add highlighted style for bulk upload error message for columnswith no underscore
3 participants
@bobbywells52 @emyl3 @mpbrown