Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated SCMS Files #20

Merged
merged 15 commits into from
Jan 30, 2024
Merged

Conversation

dmccoystephenson
Copy link
Member

@dmccoystephenson dmccoystephenson commented Dec 19, 2023

Changes

The purpose of the changes in this PR is to transition the ACM away from utilizing the 'scms-asn1' git submodule, opting instead to directly include the updated SCMS files within the project.

Git Submodule Changes

The 'scms-asn1' git submodule has been removed.

Updated SCMS Files

The SCMS files that were being used before were from 2018. These files are from 2021/2022 and include the following:

  • EtsiTs103097ExtensionModule v1.0
  • Ieee1609Dot2 v2.6
  • Ieee1609Dot2BaseTypes v2.4
  • Ieee1609Dot2Crl v3.2
  • Ieee1609Dot2CrlBaseTypes v3.2

The 'Ieee1609Dot2.asn' file depends on a structure defined in the 'EtsiTs103097ExtensionModule.asn' file.

Testing

  • The unit tests have been verified to pass with these changes.
  • The capability of the ACM to process a signed TIM for double-encoding has been verified.

Dependent PR

This PR depends on the changes made in the following PRs and should be merged after.

Copy link
Collaborator

@drewjj drewjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this always failed all CI checks?

@dmccoystephenson dmccoystephenson marked this pull request as ready for review January 18, 2024 00:26
@dmccoystephenson
Copy link
Member Author

Has this always failed all CI checks?

I don't think so. These appear to be failing due to the removal of the ASN files from source control.

@dmccoystephenson dmccoystephenson marked this pull request as draft January 19, 2024 19:56
@dmccoystephenson
Copy link
Member Author

This has been updated with the latest changes from #21 & re-deployed to the dev & test clusters.

@dmccoystephenson dmccoystephenson marked this pull request as ready for review January 29, 2024 15:31
Copy link
Collaborator

@drewjj drewjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asn1_Codec runs and functions as expected when running normal payloads through it.

Copy link

@mwodahl mwodahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Runs correctly locally + tests are passing

Copy link

@payneBrandon payneBrandon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@payneBrandon payneBrandon merged commit d565fe3 into develop Jan 30, 2024
4 checks passed
@payneBrandon payneBrandon deleted the 1609dot2/transition-to-etsi-v2.1.1 branch January 30, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants