Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified dockerfiles, added data documentation & refactored code for clarity #23

Merged
merged 5 commits into from
Feb 1, 2024

Conversation

dmccoystephenson
Copy link
Member

Problem

Dan has requested some changes on usdot-jpo-ode#42.

Solution

The changes in this pull request address the following:

  • Unnecessary instruction in dockerfiles
  • Lack of documentation for data included in the project
  • Lack of clarity for kafkaType check
  • Lack of clarity for logger setup methods

Testing

  • The program was able to be built & spun up using docker-compose locally.
  • The unit tests pass with these changes.

Copy link
Collaborator

@drewjj drewjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good

Copy link

@mwodahl mwodahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well!

@drewjj drewjj merged commit 64489b2 into develop Feb 1, 2024
4 checks passed
@drewjj drewjj deleted the addressing-usdot-pr-comments-2-1-2024 branch February 1, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants