Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transitioned to USDOT fork of asn1c repository #26

Merged
merged 8 commits into from
Jun 3, 2024

Conversation

dmccoystephenson
Copy link
Member

@dmccoystephenson dmccoystephenson commented May 24, 2024

Problem

USDOT has recently created a fork of the mouse07410/asn1c project. To maintain internal references, the project needs to switch to using this new fork.

Solution

The project now uses https://github.com/usdot-fhwa-stol/usdot-asn1c as its ASN.1 Compiler. References to the submodule have been updated in the relevant scripts and Dockerfiles.

Testing

  • Installing the asn1c tool has been verified to work
  • Generating the J2735 implementation/header files has been verified to work for 2016 & 2020
  • The docker image can be built successfully using the new 2020 generated files
  • Unit tests are verified to be passing.

Note

It should be noted that using the latest commit in usdot-fhwa-stol/usdot-asn1c results in failure to compile the ACM. To work around this, the following commit is being referenced:
usdot-fhwa-stol/usdot-asn1c@e74487c

@dmccoystephenson dmccoystephenson requested a review from drewjj May 28, 2024 16:19
Copy link
Collaborator

@drewjj drewjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looking good now.

Copy link

@mwodahl mwodahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

Copy link

@payneBrandon payneBrandon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@payneBrandon payneBrandon merged commit 2ec0826 into develop Jun 3, 2024
4 checks passed
@payneBrandon payneBrandon deleted the asn1c/transition-to-usdot-fork-of-asn1c branch June 3, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants