Added encoder topics to KAFKA_CREATE_TOPICS #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewjj
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The KAFKA_CREATE_TOPICS environment variable specified for the 'kafka' service in the
docker-compose.ymlfile does not include the input/output topics for the encoder configuration of the program. This means that developers have to manually modify the value of this environment variable in the docker-compose.yml when conducting standalone testing.Solution
The KAFKA_CREATE_TOPICS environment variable now references all four relevant kafka topics to the program:
Testing
This has been tested locally by running
docker compose up --buildwith the ACM in encoder mode and the program was able to find the required topics.