Updated do_kafka_test.sh script
#30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michael7371
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
do_kafka_test.shscript does not currently work and relies on hard-coded values for Kafka & ACM interaction.Solution
The
do_kafka_test.shscript and its dependencies have been updated & verified to be working. The DOCKER_HOST_IP is now resolved automatically and ACM docker values are explicitly set. Out of the 7 test cases the script previously ran, 4 were removed that dealt with encoding raw BSMs. The remaining test cases are centered on structures like Ieee1609Dot2Data and AdvisorySituationData that contain HEX-encoded BSMs.Testing
Running
do_kafka_test.shin WSL results in all tests passing at this time.Looking Forward
We may want to consider opening a work item to expand the test cases for this script.
Dependent PR
This
scripts/update-do-kafka-test-scriptbranch was created usingkafka/create-encoder-topicsas a base, the PR for which should be merged first:#29