-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PSM Unit Testing #1
Conversation
…rated messages, added a sample message with motor enum
… different enum cases
|
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good coverage! A couple changes are requested.
Also please add full round trip tests for each example.
j2735-2024/src/test/resources/j2735/PersonalSafetyMessage/xml/GeneratedPsm.xml
Outdated
Show resolved
Hide resolved
j2735-2024/src/test/resources/j2735/PersonalSafetyMessage/xml/GeneratedPsm.xml
Outdated
Show resolved
Hide resolved
j2735-2024/src/test/java/j2735/PersonalSafetyMessage/UserSizeAndBehaviourTest.java
Outdated
Show resolved
Hide resolved
j2735-2024/src/test/resources/j2735/PersonalSafetyMessage/xml/GeneratedPsmMessageFrame.xml
Outdated
Show resolved
Hide resolved
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
This PR includes unit tests for the PSM POJOs. The unit tests have 100% code coverage for the PersonalSafetyMessage POJO:
This PR also moves the BSM test files into the
/j2735
subdirectory to match thesrc
folder structureThis PR also includes a GitHub action configuration that calculates the code coverage of the entire project for PRs.