Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSM Unit Testing #1

Merged
merged 15 commits into from
Mar 4, 2025
Merged

PSM Unit Testing #1

merged 15 commits into from
Mar 4, 2025

Conversation

Michael7371
Copy link
Collaborator

@Michael7371 Michael7371 commented Feb 26, 2025

This PR includes unit tests for the PSM POJOs. The unit tests have 100% code coverage for the PersonalSafetyMessage POJO:

image

This PR also moves the BSM test files into the /j2735 subdirectory to match the src folder structure

This PR also includes a GitHub action configuration that calculates the code coverage of the entire project for PRs.

Copy link

Overall Project 19.83%

There is no coverage information present for the Files changed

Copy link

Overall Project 19.83%

There is no coverage information present for the Files changed

@Michael7371 Michael7371 marked this pull request as ready for review February 26, 2025 23:17
Copy link

Overall Project 21.47%

There is no coverage information present for the Files changed

Copy link
Collaborator

@iyourshaw iyourshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good coverage! A couple changes are requested.
Also please add full round trip tests for each example.

Copy link

Overall Project 36.06%

There is no coverage information present for the Files changed

Copy link

github-actions bot commented Mar 4, 2025

Overall Project 36.04%

There is no coverage information present for the Files changed

@Michael7371 Michael7371 requested a review from iyourshaw March 4, 2025 15:59
Copy link
Collaborator

@iyourshaw iyourshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@iyourshaw iyourshaw merged commit 6bcd815 into j2735-2024 Mar 4, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants