overridden: DocumentItemBody: Update renderShelfLink to use title for…

…m documentDetails
CERNDocumentServer · Jun 24, 2024 · 9c7a564 · 9c7a564
1 parent 002d437
commit 9c7a564
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 8 deletions.
diff --git a/ui/src/overridden/frontsite/Document/DocumentDetails/DocumentItemBody.js b/ui/src/overridden/frontsite/Document/DocumentDetails/DocumentItemBody.js
@@ -5,9 +5,9 @@ import {
 } from "@inveniosoftware/react-invenio-app-ils";
 import _get from "lodash/get";
 import { parametrize } from "react-overridable";
-import { shelfLinkComponent } from "../../../utils";
+import { renderCallNumber, shelfLinkComponent } from "../../../utils";
 
-function renderShelflink(item) {
+function renderShelflink(item, documentDetails) {
   const itemStatus = _get(item, "circulation.state");
 
   // If item is on loan, don't hyperlink the shelf
@@ -17,8 +17,14 @@ function renderShelflink(item) {
     _get(item, "status")
   );
 
+  const shelfNumber = _get(item, "shelf");
+  const title = _get(documentDetails, "metadata.title");
+  const callNumber = renderCallNumber(item);
+
   const itemShelf =
-    cannotCirculate && itemOnShelf ? _get(item, "shelf") : shelfLinkComponent(item);
+    cannotCirculate && itemOnShelf
+      ? shelfNumber
+      : shelfLinkComponent(shelfNumber, title, callNumber);
   return itemShelf;
 }
 

diff --git a/ui/src/overridden/utils.js b/ui/src/overridden/utils.js
@@ -38,11 +38,15 @@ export const shelfLink = (shelfNumber, { popupContent = null, iframe = false })
   return shelfLink;
 };
 
-export const shelfLinkComponent = (item, iconName = "map pin") => {
-  const shelfNumber = _get(item, "shelf");
-  const callNumber = renderCallNumber(item);
-  const popupContent = { "Title": item.title, "Call number": callNumber };
-  const linkToShelf = shelfLink(shelfNumber, { popupContent: popupContent });
+export const shelfLinkComponent = (
+  shelfNumber,
+  title,
+  callNumber,
+  iconName = "map pin"
+) => {
+  const linkToShelf = shelfLink(shelfNumber, {
+    popupContent: { "Title": title, "Call number": callNumber },
+  });
   return (
     <>
       {shelfNumber && (