importer: Create new audiobook for document with existing e-book #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpsherva
reviewed
May 23, 2024
kpsherva
reviewed
May 23, 2024
| "document_pid": "docid-9", | ||
| "eitem_type": "AUDIOBOOK", | ||
| "eitem_type": "E-BOOK", |
There was a problem hiding this comment.
correct me if I am wrong but we will lose the test case for AUDIOBOOK creation in this way, no? is there other one?
There was a problem hiding this comment.
AUDIOBOOK creation is already there, this was for updating existing AUDIOBOOK, I will add another item here to cover that if you think it might be necessary, but it will be similar to pre-existing update E-BOOK case, WDYT?
There was a problem hiding this comment.
I think it could be useful to check the exact case that was pointed out to us, if audiobook is created when there is already e-book of the same provider existing
ntarocco
approved these changes
May 27, 2024
kpsherva
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #865