Avoid division-by-zero on 0-weights

CISC · web-flow · commit 0225cfbfb3e1 · 2024-06-07T23:57:04.000+02:00
diff --git a/ggml-quants.c b/ggml-quants.c
@@ -1754,7 +1754,7 @@ static float make_q3_quants(int n, int nmax, const float * restrict x, int8_t *
         for (int i = 0; i < n; ++i) {
             L[i] += nmax;
         }
-        return sumlx / suml2;
+        return suml2 ? sumlx / suml2 : 0.0f;
     }
     for (int i = 0; i < n; ++i) {
         int l = nearest_int(iscale * x[i]);
@@ -2158,7 +2158,7 @@ static float make_qp_quants(int n, int nmax, const float * restrict x, uint8_t *
             break;
         }
     }
-    return sumlx/suml2;
+    return suml2 ? sumlx/suml2 : 0.0f;
 }
 
 static void quantize_row_q2_K_impl(const float * restrict x, block_q2_K * restrict y, int k, const float * restrict quant_weights) {

Original file line number	Diff line number	Diff line change
`@@ -1754,7 +1754,7 @@ static float make_q3_quants(int n, int nmax, const float * restrict x, int8_t *`
`1754`	`1754`	`for (int i = 0; i < n; ++i) {`
`1755`	`1755`	`L[i] += nmax;`
`1756`	`1756`	`}`
`1757`		`- return sumlx / suml2;`
	`1757`	`+ return suml2 ? sumlx / suml2 : 0.0f;`
`1758`	`1758`	`}`
`1759`	`1759`	`for (int i = 0; i < n; ++i) {`
`1760`	`1760`	`int l = nearest_int(iscale * x[i]);`
`@@ -2158,7 +2158,7 @@ static float make_qp_quants(int n, int nmax, const float * restrict x, uint8_t *`
`2158`	`2158`	`break;`
`2159`	`2159`	`}`
`2160`	`2160`	`}`
`2161`		`- return sumlx/suml2;`
	`2161`	`+ return suml2 ? sumlx/suml2 : 0.0f;`
`2162`	`2162`	`}`
`2163`	`2163`
`2164`	`2164`	`static void quantize_row_q2_K_impl(const float * restrict x, block_q2_K * restrict y, int k, const float * restrict quant_weights) {`