Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loop Refactor src/flags.js #152

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Loop Refactor src/flags.js #152

wants to merge 2 commits into from

Conversation

dacontre
Copy link

@dacontre dacontre commented Jan 23, 2025 •
edited
Loading

fixes #142 by refactoring loop in flags.update

@dacontre dacontre changed the title Loop Refactor Loop Refactor src/flags.js Jan 23, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12936473828

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.004%) to 82.667%
Files with Coverage Reduction New Missed Lines %
src/meta/errors.js 1 76.74%
Totals Coverage Status
Change from base Build 12896760049: -0.004%
Covered Lines: 22324
Relevant Lines: 25584
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor this function to reduce its Cognitive Complexity from 26 to the 15 allowed in src/flags.js
2 participants
@dacontre @coveralls