Refactoring code in src/admin/admin.js (<4 nesting levels) #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I used ChatGPT4 to write the following lines: 15-35, 45, 47, 50, 56-57, 72, 74-83, 100, 107, 209-231 |
Pull Request Test Coverage Report for Build 13220937056Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #27 (less than 4 levels of nesting, as opposed to under 5 levels). I made the logic for the more deeply nested functions into separate functions that were less embedded. For example, I coded the functions initlogout_message and showlogout_alert() and then called them in startLogoutTimer() so it included their logic. This considerably simplified the if (!logoutMessage) method and the logoutTimer variable. I also made the config_AjaxifyHooks(hooks, Settings) function and hooked it on to updatePageTitle(data.url), setupRestartLinks(), showCorrectNavTab(), startLogoutTimer(), setupToolTips(), and initializeSettings(Settings). Finally, I called config_AjaxifyHooks(hooks, Settings) inside the document ready function (moved to the bottom of my code).