Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test checking pin button visibility [DO NOT ACCEPT] #43

Closed
wants to merge 4 commits into from

Conversation

karengc27
Copy link

@karengc27 karengc27 commented Oct 10, 2024

EDIT: ISSUE WITH A COMMIT DELETING FRONT END MODULE
Not sure how this commit was made and why "Submodule [nodebb-theme-quickstart] deleted from [fa9a84]", so please do not accept this PR.

This test case checked to make sure there would be an error when a non-admin user tries to pin a post since they don't have the privileges necessary to do so.

Added test case in nodebb-f24-team-sweepers/test/topics.js

This is what the view looks like for a non-admin account which does not and should not be able to see the pin button.
Screenshot 2024-10-10 at 11 25 51 AM

@karengc27 karengc27 added this to the Sprint 2 milestone Oct 10, 2024
@karengc27 karengc27 requested a review from Alanna-Cao October 10, 2024 05:45
@karengc27 karengc27 changed the title Added test to check that pin button was only visible for admin Test checking pin button visibility Oct 10, 2024
Copy link

@Alanna-Cao Alanna-Cao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@karengc27 karengc27 changed the title Test checking pin button visibility Test checking pin button visibility [IGNORE] Oct 10, 2024
@karengc27 karengc27 changed the title Test checking pin button visibility [IGNORE] Test checking pin button visibility [DO NOT ACCEPT] Oct 10, 2024
@Alanna-Cao Alanna-Cao closed this Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants