Test Checking Pin Button Visibility #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karengc27
changed the title
karengc27
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test case checked to make sure there would be an error when a non-admin user tries to pin a post since they don't have the privileges necessary to do so.
Added test case in nodebb-f24-team-sweepers/test/topics.js
Test case checks that a regular user that is not admin does not have access to pin button or functionality.
Note: issues with committing front-end submodule occurred, this is my attempt at fixing them. I made the same changes as #43 , so the commits in that pull request reflect the actual commits made. This pull request is to avoid an issue that the front-end repo caused when committing for pull request 43, and to not cause any errors on the sprint2-main branch.
This is what the view looks like for a non-admin account which does not and should not be able to see the pin button.
This is what it looks like when user is admin:
