Frontend integration code for flagging priority questions for faculty issue #12 #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjpatel04
reviewed
Feb 27, 2025
There was a problem hiding this comment.
You have a stray tag after the first that could possibly be removed. Everything else structure wise looks good. Gook work!
|
Overall, this is clean, readable code that effectively handles the key logic for marking a question as resolved and sending notifications. For future improvements, consider extracting common functionality into helper functions to reduce repetition, and ensure that error handling is consistent throughout (e.g., standardized error messages). You might also add brief comments describing the purpose of each step to help new contributors understand the workflow at a glance. |
|
I left a comment on your sort.tpl file that you edited dealing with tags and structure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the frontend code to link backend features from pull request #13. Wrote the html code that retrieved the priority level the student assigned to their comment and then flags the comment with a color based on the priority level. Green is for priority level 1 (low priority), yellow is for priority level 2 (medium priority), red is for priority level 3 (high priority).
This is a response to issue #12.
files changed:
nodebb-theme-harmony/templates/partials/topic/post.tpl
public/src/client/topic/postTools.js