Fully functional implementation for #9 #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sharkesh111
reviewed
Feb 27, 2025
There was a problem hiding this comment.
Hey, this code looks good. Just a heads up for next time, make sure to leave some comments on what the functions are doing because it took me a little bit to understand what this was affecting. Other than that, good work.
Sharkesh111
reviewed
Feb 27, 2025
There was a problem hiding this comment.
Great job adding getting the notification feature implemented.
Sharkesh111
reviewed
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the Fully functional implementation for #9
It now has a new category called question, two groups called instructor and Students
Now, if a student posts in the Questions category, instructors will get notified
Files changed:
install/data/categories.json
src/install.js
src/posts/create.js
If you pull the code and it does not work on your end, try to flush your Redis database, then redo the setup and build the app.
This one may not pass the lint and coverage test, will verify this on the next PR