Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

**Supplimental** adding the written but buggy file to the repo #8

Closed
wants to merge 5 commits into from

Conversation

Caryzxy
Copy link
Contributor

@Caryzxy Caryzxy commented Feb 15, 2025

This is just a pull request to document my work. It is buggy, please don't merge it.

I used to think that for 2B, we only need a pull request for whatever things. So I just did a PR of what I changed in HW 1 and kept the buggy code I have for HW2 local.

However, after a talk with a TA and Professor Austin today, it seems like that although not said in the handout, but the PR for 2b should be about the changes we made for this assignment, as we have to show that we are working on it.

So sorry that my first impression on the 2b requirement is really just that we can do a PR of whatever we want. So here I create this PR just to show that I do have work done. The work was also shown on the presentation on Monday recitation.

I did do a PR before the ddl ! its just that that PR may not be what we wanted because of some of my confusions.

OK...

So in this PR I changed the create function in the src/notification.js. It is still buggy, but intended to see if this notification is to send to all instructors.

@Caryzxy Caryzxy closed this Feb 23, 2025
@Sharkesh111
Copy link
Contributor

Sounds good. Thanks for informing us to not merge this code. Whenever you finish the implementation, just create a new pull request and me and tj can review that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants