Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Implement Handle Tag Functionality #22

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

alondrarobles
Copy link
Contributor

This pull request adds handling tags functionality to the the request user input and attempts to save this whitelist of defaults tags.

Changes Implemented:

  • Added a highlighting of inputted tags in public/src/admin/manages/categories.js
  • Passed default tag whitelist to with other form data to be initialized upon the creation of a new category in public/src/admin/manages/categories.js

Problems Faced
I unfortunately did not get the default tag whitelist inputted to actually save to the database. I spent over 3 hours trying to figure where to code was passing through the form data to the backend. Once I figured out how to do that I adding passing in the users inputted default tag whitelist. However, I noticed the redirection to the newly created category didn't actually show the new default tag whitelist. I then looked at other place in the code where data was being saved and noticed the type being passed through where different so I updated the default tag whitelist to be passed through as a string, but that didn't fix it. I then noticed the return data from the newly created category had the tag whitelist as an array so I change back the way I passed the default tag whitelist. I then made sure that tag whitelist was being passed through with the form data through using console logs and it was. I went to office hours a couple times and were not able to resolve the issue. This seems to be an issue with saving things to the database and did not have enough time to learn what additional things might be required to update the database

Steps to test
From the nodeBB homepage go to admin, then manage, then categories. From the categories page click new category and you can now see an input section for a default tag whitelist.

Video Showing my Change in Action
https://drive.google.com/file/d/1FbTcDUAf0JE4wCuAsEjsrXWl1HN96G-L/view?usp=sharing

Resolves #7

@alondrarobles alondrarobles added the frontend Frontend development label Feb 28, 2025
@alondrarobles alondrarobles added this to the Sprint 2 milestone Feb 28, 2025
@alondrarobles alondrarobles self-assigned this Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Frontend development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate form request with backend categories route
1 participant