Feature Send notifications when a question is resolved #8 #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ping it in. this will mark the topic as resolved, and will unmark it as resolved if the tag is removed
…/tags.js. additionally added functionality for sending out notifications for all people watching a topic when it becomes marked as resolved or unmarked as resolved
Ginka3
changed the title
…s.js for unit tests
…t/topics.js for unit tests
Pull Request Test Coverage Report for Build 13560569247Details
💛 - Coveralls |
|
Great job, Jason! Looked over the testing for unit tests and integration tests and they look good. Nice job keeping your PR organized and clear to understand. Great addition to the Question resolved feature! |
|
Awesome job! The API and notifications code all look fine. The unit and integration tests are very comprehensive. Overall, very clear and organized. The PR is also clean and easy to understand! |
|
Great work – full test coverage of new features, lint/test running smoothly, organized descriptions of code structure and functionality. LGTM! |
Ginka3
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Context
Currently working branch which allows a user to 'tag' a topic as resolved by using the existing functionality. Marker appears in the main menu screen and is able to be searched. Accomplished by adding to the topic title "resolved" in public/src/client/topic.js and updates the topic backend existing resolved status to true/false accordingly.
Uses NodeBB's built-in notification system to notify watchers and the original poster (OP) when a topic's resolved status changes.
Helps users stay updated when a topic they are following gets answered or reopened.
✅ Changes in the Codebase
Added API to set resolved status and trigger notifications
Modified: src/controllers/topics.js
Added: setResolved() function to update the topic status and notify watchers
Sends a notification when a topic is marked resolved or unresolved
Updated UI to visually indicate resolved topics
Modified: public/src/client/topic.js
Appends a "Resolved" badge to topic titles when marked resolved
Integrated notifications for topic watchers
Modified: src/topics/tags.js
When a topic tag changes to "resolved", watchers are notified
WebSocket Integration
Modified: src/controllers/topics.js
Emits event:topicResolvedUpdated to notify the frontend when a topic’s status changes