[READY FOR REVIEW] Backend API for Filtering Unanswered Questions #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et unanswered questions api completely working
…trollers and installed new jest framework reflected in package.json
…ed test/controllers/topics.js to modify formatting of output to adhere to schema expectations. changed public/openapi/read.yaml to add definition of unanswered api
…/controllers.js and deleted the created directory of test/controllers/ because it was not synced properly with other tests; also fixed all lint issues. added chai to devDependencies in package.json
…id as a parameter to check for admin privileges before allowing filtering for unanswered questions
…est/controllers.js
roller again to log clearer console errors. completed full integration tests and c reated new file in src/api/unanswered.js
…routes/api.js to correctly connect with the db. modified test file to correctly match output. code coverage reached all yellow
…sues + Edited unit tests in test/controllers.js + Edited getUnansweredTopics function in src/controllers/topics.js to include numThumbs and thumbs field within return array
sophiazhuu
changed the title
… + Reverted code in .github/worflows/test.yaml and package.json
|
Great work on implementing the unanswered questions filter API! Looks well-structured and the refactored response format improves consistency |
|
The unanswered questions filter API and all the backend code look comprehensive and correct! The tests also seem to cover all the necessary functionalities. Overall, everything looks good, and the pull request is very clear and understandable. |
…opics for an admin user test in test/topics.js
…er in test/topics.js
…to show that what she had originally worked in both functionality and testing but was not passing lint + node tests due to external modules used
…to show that what she had originally worked in both functionality and testing but was not passing lint + node tests due to external modules used. Got rid of comments in her code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Context
This PR introduces the backend API for filtering unanswered questions. This feature will be useful for instructors and TAs which questions from students still require help, and can make the NodeBB process smoother and more efficient.
✅ Changes in Codebase
Modified Files:
Created Files:
🧠 Summary of Changes
The correct topicsController for unanswered questions and its corresponding route was created in src/controllers/topics.js and src/routes/api.js respectively; unit tests and integration tests can be found in test/controllers.js and test/topics.js respectively.
All additional files were changed for data validation and to match testing outputs format to database output formats.
Full unit and integration tests are completed and passed in this PR.