Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified code in nodebb-theme-harmony/templates/topic.tpl #13

Merged
merged 5 commits into from
Feb 28, 2025

Conversation

eenkhbol
Copy link
Contributor

@eenkhbol eenkhbol commented Feb 7, 2025

This pull request adds a placeholder search bar to discussion topics so that we can search replies by keyword. It's placed in the same location as search bars on other pages for consistency.

Before:
Screenshot 2025-02-07 at 6 08 08 AM

After:
Screenshot 2025-02-07 at 6 07 06 AM

*Note:
This is only the front-end design; the search functionality isn't active yet.

Partially resolves #20

…cussion topics.

The search bar is located next to the topic title in the header similar to other pages such as the Groups or Users page.
BREAKING CHANGE: None.
@phiofuni phiofuni added this to the Sprint 1 milestone Feb 27, 2025
@eenkhbol eenkhbol self-assigned this Feb 27, 2025
@eenkhbol eenkhbol added the enhancement New feature or request label Feb 27, 2025
@coveralls
Copy link

coveralls commented Feb 28, 2025

Pull Request Test Coverage Report for Build 13581001464

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.309%

Totals Coverage Status
Change from base Build 13580975937: 0.0%
Covered Lines: 22342
Relevant Lines: 25704

💛 - Coveralls

@eenkhbol eenkhbol merged commit 5b18480 into main Feb 28, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search Topics by keywords under specific categories
5 participants