Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified code in src/user/blocks.js to show replies from blocked users #17

Merged
merged 9 commits into from
Feb 28, 2025

Conversation

eenkhbol
Copy link
Contributor

@eenkhbol eenkhbol commented Feb 21, 2025

This pull request deletes the following line of code that is responsible for removing entries made by blocked uids:
set = set.filter(item => !blockedSet.has(parseInt(isPlain ? item : (item && item[property]), 10)));

Context:
The set variable contains different properties (discussions, posts, etc.) and the blockedSet variable contains the user IDs of blocked users.

Reason for deletion:
Since this line filters out items from the set where the uid matched a blocked user, deleting it allows users to see all discussion posts regardless of whether the user who created them is blocked or not.

Resolves #11

@eenkhbol eenkhbol self-assigned this Feb 21, 2025
Copy link
Contributor

@arjuanwall arjuanwall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eenkhbol eenkhbol added the enhancement New feature or request label Feb 27, 2025
@coveralls
Copy link

coveralls commented Feb 27, 2025

Pull Request Test Coverage Report for Build 13580920816

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 82.314%

Totals Coverage Status
Change from base Build 13580700080: 0.008%
Covered Lines: 22343
Relevant Lines: 25704

💛 - Coveralls

@phiofuni phiofuni added this to the Sprint 2 milestone Feb 28, 2025
@eenkhbol eenkhbol merged commit a194600 into main Feb 28, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unblock users for certain topics
4 participants